Add RateLimit effect for rate-based access control#1620
Open
Add RateLimit effect for rate-based access control#1620
Conversation
|
|
Benchmark ComparisonComparing base branch ( 🤖 This comment will be automatically updated with the latest benchmark results. |
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add new Effect to support rate limiting
Add RateLimit effect for rate-based access control
Dec 23, 2025
c622095 to
b190fce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends Casbin's effect system beyond binary allow/deny to support rate-limited access control.
Changes
RateLimiteffect constant toeffector.Effectenum"rate_limit"string in policy definitions (alongside existing"allow"and"deny")DefaultEffector.MergeEffects()to handleRateLimitin all effect modes with priority order: Allow > RateLimit > DenyRateLimitevaluates totrue(allowed access), semantic distinction enables downstream rate limiting implementationUsage
Priority semantics in DenyOverrideEffect mode: deny rules short-circuit, otherwise allow rules take precedence over rate_limit rules, which take precedence over no-match fallback.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.